Fix an issue with the CI pipeline.#302
Merged
Merged
Conversation
The getGitHubOrg() function used a regex with .+? (lazy match any character) to extract the organization name from a git remote URL. This worked for SSH URLs (git@github.com:ORG/rushstack-websites.git) but failed for HTTPS URLs (https://github.com/microsoft/rushstack-websites) used by GitHub Actions, incorrectly returning '//github.com/microsoft' instead of 'microsoft'. This caused the build to incorrectly detect itself as a fork build, setting baseUrl='/rushstack-websites/<package>/' instead of '/', which caused Docusaurus to flag internal links as broken (onBrokenLinks: 'throw'). The fix changes .+? to [^:/]+ to prevent matching across path delimiters. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
deploy-fork/scripts/build.js copies the build output of all 7 websites, but package.json only declared 3 of them as dependencies. Rush would schedule deploy-fork to run as soon as those 3 deps finished, while the other 4 websites (api-extractor.com, heft.rushstack.io, lfx.rushstack.io, tsdoc.org) could still be building in parallel. When deploy-fork tried to copy their build/ directories, they didn't exist yet, causing an ENOENT failure. Rush then waited for all running builds to finish before reporting the error, producing the consistent ~12-minute build failure. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
octogonz
approved these changes
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.